Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport "Don't re-balance AndTypes arising from supertypes" to LTS #21124

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #20400 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

#20284 started breaking since we now balance AndTypes to avoid performance drops.
But (re-)balancing an AndType interferes with the logic that determines which
symbol is referred by a super select. This is fixed by two changes:

 - Form types of super with `AndType` instead of `&`
 - Don't simplify types of super since that would rebalance the underlying AndTypes.

Fixes #20284

[Cherry-picked f0560b2]
Base automatically changed from lts-20444 to lts-3.3 July 9, 2024 16:54
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-20857.

Reference

@WojciechMazur WojciechMazur merged commit fd363fc into lts-3.3 Jul 9, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-20400 branch July 9, 2024 16:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants