Upgrade to Babel 7 #3275
Merged
Upgrade to Babel 7 #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (1368 commits) restart count starts at 0 not 1 retry task assignment on transaction serialization failure enable admins to edit dataset default configurations (#2462) properly run slick transactions run task assignment without sql view add script to run refresh_schema on a dev-branch deployment (#2478) annotations are initialized atomically (deleted on failure) Shows error message of invalid datasource in import screen (#2479) WIP: initialize annotation in task assignment fix sql query to reset tasks to base (#2481) added PR feedback changed lastname of testing-db users updated snapshots added organization to DatasetUploadView write organization to User json WIP: upload dataset needs to send organization now instead of team fixed dataset search make it easier to select nodes when particleSize is small (#2474) Update README.md fix task from file (id is string, not bsonId) ...
philippotto
approved these changes
Sep 25, 2018
.babelrc
Outdated
| ], | ||
| "plugins": [ | ||
| "@babel/plugin-proposal-class-properties", | ||
| // Currently broken (as of 1.9.1) - does not rename the import (_select) in a line like `const { Option } = Select;` |
There was a problem hiding this comment.
Is there an issue we can track? This will blow up the bundle size a bit, since there won't be any tree shaking for antd, right?
There was a problem hiding this comment.
I couldn't find an issue in the babel-plugin-import repo. I've tried to repro on codesandbox, but the plugin doesn't seem to be applied there (https://codesandbox.io/s/8k17q911y2), didn't find out why yet. Nevertheless, this will only affect the tests, so I think there wasn't even any tree shaking to begin with.
| context.cube = cube; | ||
| context.pullQueue = pullQueue; | ||
| context.pushQueue = pushQueue; | ||
| t.context = { |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentationjs upgraded to babel v7 some days ago, so now we can also switch to babel v7 :)
Babel v7 Perks:
/*#__PURE__*//cc: @hotzenklotz
URL of deployed dev instance (used for testing):
Steps to test:
Issues: