Skip to content

Updates to helm charts to sync with SGP #651

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

dmchoiboi
Copy link
Collaborator

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Ingest updates from SGP

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@dmchoiboi dmchoiboi requested review from yunfeng-scale and seanshi-scale and removed request for yunfeng-scale October 30, 2024 00:12
Copy link
Contributor

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this shouldn't change any existing behavior? lgtm

@dmchoiboi dmchoiboi merged commit 785e0fa into main Oct 30, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/helm-chart-updates branch October 30, 2024 00:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants