Skip to content

Updates to helm charts to sync with SGP #651

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/model-engine/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.3
version: 0.1.4

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/model-engine/templates/balloon_deployments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ spec:
---
{{- end }}
{{- end }}
{{- end }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,4 @@ spec:
name: config-volume
{{- end}}
{{- end }}
{{- end }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ data:
gpu_type: {{ .gpu_type }}
nodes_per_worker: {{ .nodes_per_worker }}
{{- end }}
{{- end }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ metadata:
{{- end }}
---
{{- end }}
{{- end }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ imagePullSecrets:
- name: egp-ecr-regcred
{{- end }}
---
{{- end }}
{{- end }}
10 changes: 8 additions & 2 deletions charts/model-engine/templates/service_template_config_map.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -464,13 +464,19 @@ data:
- type: redis
metadata:
address: ${REDIS_HOST_PORT} # Format must be host:port
{{- if not .Values.redis.enableAuth }}
passwordFromEnv: ""
{{- end }}
listName: "launch-endpoint-autoscaling:${ENDPOINT_ID}"
listLength: "100" # something absurdly high so we don't scale past 1 pod
activationListLength: "0"
enableTLS: "false"
unsafeSsl: "false"
enableTLS: "{{ .Values.redis.enableTLS }}"
unsafeSsl: "{{ .Values.redis.unsafeSsl }}"
databaseIndex: "${REDIS_DB_INDEX}"
{{- if .Values.redis.enableAuth }}
authenticationRef:
name: "keda-trigger-auth-redis-secret"
{{- end }}
{{- end }}
- type: prometheus
metadata:
Expand Down
15 changes: 14 additions & 1 deletion charts/model-engine/templates/trigger_authentication.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,17 @@ spec:
podIdentity:
provider: azure-workload
identityId: {{ .Values.azure.client_id }}
{{- end }}
{{- else if .Values.redis.enableAuth }}
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
name: keda-trigger-auth-redis-secret
namespace: {{ .Values.config.values.launch.endpoint_namespace }}
spec:
awsSecretManager:
podIdentity:
provider: aws
secrets:
- parameter: password
name: {{ .Values.redis.kedaSecretName }}
{{- end }}
4 changes: 4 additions & 0 deletions charts/model-engine/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ spellbook:
enabled: false
redis:
auth:
enableTLS: false
enableAuth: false
kedaSecretName: ""
unsafeSsl: false
db:
runDbInitScript: false
runDbMigrationScript: false
Expand Down