Bugfix: arrays returned as objects like {"0":... } #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes an array gets returned as {"0":..., "1":...} instead of [..., ...]. Furthermore, this behaviour only appears at the root; when nesting arrays only the root is affected. I have seen multiple users being confronted to this bug. It is pretty annoying.
This is how I understand the code: In this part of the code, you assume that empty($rs) && array() === $this->getRoot() imply that the root is an empty array, that should then be returned as {} instead of []. But you don't actually check that you are at the root. That is the check I add.