-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bugfix: arrays returned as objects like {"0":... } #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix: the root could be modified when it shouldn't
Fix tests
To test it:
Without the fix, the serializer return: {"0":{"id":"what_a_nice_id","title":"#1 This is a nice title.","is_published":false,"etag":"1edf9bf60a32d89afbb85b2be849e3ceed5f5b10","author":{}},"1":{"id":"what_a_nice_id","title":"#2 This is a nice title again.","is_published":false,"etag":"1edf9bf60a32d89afbb85b2be849e3ceed5f5b10","author":{}}} instead of: [{"id":"what_a_nice_id","title":"#1 This is a nice title.","is_published":false,"etag":"1edf9bf60a32d89afbb85b2be849e3ceed5f5b10","author":{}},{"id":"what_a_nice_id","title":"#2 This is a nice title again.","is_published":false,"etag":"1edf9bf60a32d89afbb85b2be849e3ceed5f5b10","author":{}}] |
👍 |
What's up on this PR? |
j-ledoux
added a commit
to j-ledoux/serializer
that referenced
this pull request
Jun 5, 2015
j-ledoux
added a commit
to j-ledoux/serializer
that referenced
this pull request
Jun 5, 2015
👍 |
1 similar comment
+1 |
Is this actually a fix for THE bug? Anyone maintaining this repo still? |
Have you tried with the last release of this repo? Seems the last commits fixed this pb on my projects. |
You're ABSOLUTELY right. Composer update did it. Thanks! My bad, but shouldn't this PR be closed, and along with it all the issues related to it? |
Agree to close this issue 👍 . |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added #304