feat: make matplotlib core dependency and refactor visualization code #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns
matplotlib
into a core dependency. As a result,contrib.visualize_matplotlib
is moved into submodules ofvisualize
instead, with the functionality split up into three new components:visualize.plot_model
(visualize fit model: data/MC, templates),visualize.plot_result
(visualize inference results: correlation, pulls, ranking, scan, limit),visualize.utils
(utilities, currently just figure saving).The change allows for some simplifications in the
visualize
API, where themethod
kwarg is dropped.Breaking changes:
method
kwarg removed fromvisualize
APIcontrib.matplotlib_visualize
no longer exists, functionality is split up intovisualize.plot_model
,visualize.plot_results
andvisualize.utils