Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: install Ghostscript in nightly tests #253

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Aug 10, 2021

The refactoring in #250 caused the nightly tests to fail. They previously skipped the figure comparison completely, but since that is now split across multiple files, some figures end up being left open and the test fails. This installs Ghostscript in the nightly tests to make them pass, and no longer skip figure comparisons.

* install Ghostscript in nightly tests for figure comparisons

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #253 (8836efd) into master (12b4af9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1720      1720           
  Branches       261       261           
=========================================
  Hits          1720      1720           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4af9...8836efd. Read the comment docs.

@alexander-held alexander-held merged commit 8b93c98 into master Aug 10, 2021
@alexander-held alexander-held deleted the test/ghostscript-nightly branch August 10, 2021 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant