-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: histogram inputs #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 23 +4
Lines 1808 1878 +70
Branches 283 295 +12
=========================================
+ Hits 1808 1878 +70
Continue to review full report at Codecov.
|
bb01f0c
to
578e673
Compare
This was referenced Oct 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to use analyzer-provided histograms instead of ntuples as input. This is done via approach 4) described in #219: The configuration schema is (slightly) expanded to support specification of paths to histograms, and the first step in a workspace-building workflow is to read the user-provided histograms and save them in the manner that
cabinetry
expects for further internal usage. Only a single histogram is supported per template thatcabinetry
needs, though this may be expanded in the future (#291).additions:
contrib.histogram_reader
to read histograms with uproottemplates.collector
to collect histograms and store them in thecabinetry
-internal format for subsequent processing (the wholetemplates
module is new, but contains refactored functionality, see below)Breaking changes:
template_builder
andtemplate_postprocessor
, moved high-level functionality intotemplates
and lower-level features into submodulestemplates.creator
andtemplates.postprocessor
template_builder.create_histograms
->templates.create
template_postprocessor.run
->templates.postprocess
contrib.histogram_creation
tocontrib.histogram_creator
, and thefrom_uproot
function contained within towith_uproot
SamplePaths
config option renamed toSamplePath
resolves #219