feat: region- and sample-specific paths are optional for histogram inputs #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1878 1878
Branches 295 295
=========================================
Hits 1878 1878 Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the config schema to make
RegionPathandSamplePathoptional for histogram inputs. #289 already introduced all the logic required to handle that scenario, but made the schema restrictive and required both these settings. WhileSamplePathis likely needed for most/all setups,RegionPathis not needed for single-distribution fits.