feat: add Python 3.11 support #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Python 3.11 to testing in CI. * Default to using Python 3.11 in GitHub Actions where possible. * Update to using Python 3.11 in mypy pre-commit hook. * Add Python 3.11 trove classifier to PyPI metadata.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 23
Lines ? 2078
Branches ? 334
==========================================
Hits ? 2078
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
alexander-held
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Thanks a lot for taking care of this! With the pyhf support via scikit-hep/pyhf#2145 it's great to now also officially support Python 3.11.
related previous PR for 3.10 was #334
* add Python 3.11 to testing in CI and default to using it where possible
* add Python 3.11 trove classifier to PyPI metadata
alexander-held
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given scikit-hep/pyhf#2145 and discussion in conda-forge/cabinetry-feedstock#3 add Python 3.11 to testing for
cabinetry.