Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: move state commitments to apply stage #802

Closed
wants to merge 6 commits into from

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Jun 5, 2024

1. Purpose or design rationale of this PR

according to our mainnet metrics, apply stage spends %30 of its time stalled (ie waiting for CCC stage). If we move the commitment calculation to apply stage, we should be able to make use of a part of this %30.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

0xmountaintop
0xmountaintop previously approved these changes Jun 5, 2024
georgehao
georgehao previously approved these changes Jun 5, 2024
@omerfirmak omerfirmak dismissed stale reviews from georgehao and 0xmountaintop via 25b93b8 June 6, 2024 09:24
@omerfirmak omerfirmak marked this pull request as draft June 6, 2024 12:33
@omerfirmak
Copy link
Author

closing in favor of #814

@omerfirmak omerfirmak closed this Jun 13, 2024
@0xmountaintop 0xmountaintop deleted the omerfirmak/commit-in-apply branch June 13, 2024 08:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants