Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: introduce encode stage #814

Merged
merged 6 commits into from
Jun 12, 2024
Merged

feat: introduce encode stage #814

merged 6 commits into from
Jun 12, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Jun 10, 2024

1. Purpose or design rationale of this PR

JSON encode/decode step takes %50 of CCC runtime. Splitting it to a seperate stage makes tracing the new bottleneck, which is a more comfortable position to be in since we didn't attempt to optimize it yet.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Copy link

@jonastheis jonastheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON encode/decode step takes %50 of CCC runtime

How exactly are you benchmarking these improvements? I couldn't find any benchmarks or tests disguised as benchmarks on this. Would be great to have some objective measure to look at.

@omerfirmak
Copy link
Author

JSON encode/decode step takes %50 of CCC runtime

How exactly are you benchmarking these improvements? I couldn't find any benchmarks or tests disguised as benchmarks on this. Would be great to have some objective measure to look at.

Benchmarks are done on live mainnet data, so there is no clean way of putting that in a reproducable way.

jonastheis
jonastheis previously approved these changes Jun 11, 2024
0xmountaintop
0xmountaintop previously approved these changes Jun 11, 2024
@omerfirmak omerfirmak dismissed stale reviews from 0xmountaintop and jonastheis via 2bad47d June 11, 2024 14:31
@omerfirmak omerfirmak merged commit 84cf1b5 into develop Jun 12, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/json-stage branch June 12, 2024 08:11
Thegaram added a commit that referenced this pull request Jun 12, 2024
omerfirmak added a commit that referenced this pull request Jun 12, 2024
omerfirmak added a commit that referenced this pull request Jun 13, 2024
* Reapply "feat: introduce encode stage (#814)"

This reverts commit 0b6cdbd.

* reintroduced nullifying txnQueue
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Jun 25, 2024
* Reapply "feat: introduce encode stage (scroll-tech#814)"

This reverts commit 0b6cdbd.

* reintroduced nullifying txnQueue
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants