-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: introduce encode stage #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON encode/decode step takes %50 of CCC runtime
How exactly are you benchmarking these improvements? I couldn't find any benchmarks or tests disguised as benchmarks on this. Would be great to have some objective measure to look at.
Benchmarks are done on live mainnet data, so there is no clean way of putting that in a reproducable way. |
2bad47d
This reverts commit 0b6cdbd.
* Reapply "feat: introduce encode stage (scroll-tech#814)" This reverts commit 0b6cdbd. * reintroduced nullifying txnQueue
1. Purpose or design rationale of this PR
JSON encode/decode step takes %50 of CCC runtime. Splitting it to a seperate stage makes tracing the new bottleneck, which is a more comfortable position to be in since we didn't attempt to optimize it yet.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?