Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

the os dashboard should accept multiple node_exporter jobs #2317

Closed
amnonh opened this issue Jun 12, 2024 · 1 comment · Fixed by #2327
Closed

the os dashboard should accept multiple node_exporter jobs #2317

amnonh opened this issue Jun 12, 2024 · 1 comment · Fixed by #2327
Labels
enhancement New feature or request
Milestone
Monitoring 4.8

Comments

@amnonh
Copy link
Collaborator

amnonh commented Jun 12, 2024

to avoid conflict with different systems, the os dashboard filters metrics that come from the node_exporter job,
it's too restrictive, it's hard to add metrics not through the node_exporter file.

We need to make the filter pick multiple jobs, we'll start with accepting any job that starts with node_exporter
@amnonh amnonh added the enhancement New feature or request label Jun 12, 2024
@amnonh amnonh mentioned this issue Jun 12, 2024
Closed
2 tasks
@amnonh amnonh added this to the Monitoring 4.8 milestone Jun 12, 2024
amnonh added a commit to amnonh/scylla-grafana-monitoring that referenced this issue Jun 24, 2024
@amnonh
scylla-os: support multiple node_exporter targets
46ff5cb 
There are situations that a user would like to add more node_exporter
targts, this patch makes the os dashboard suppport any job that is
prefixed by node_exporter.

Fixes #scylladb#2317

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
@amnonh amnonh mentioned this issue Jun 24, 2024
Merged
@amnonh
Copy link
Collaborator Author

amnonh commented Jun 24, 2024

Fixed by #2327

@amnonh amnonh closed this as completed Jun 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Monitoring 4.8
Development

Successfully merging a pull request may close this issue.

scylla-os: support multiple node_exporter targets amnonh/scylla-grafana-monitoring
1 participant
@amnonh