Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] Configurable flush parameters #135

Closed
2 tasks
lubird opened this issue Oct 5, 2020 · 0 comments · Fixed by #148
Closed
2 tasks

[Feature] Configurable flush parameters #135

lubird opened this issue Oct 5, 2020 · 0 comments · Fixed by #148
Assignees
@nd4p90x

Comments

@lubird
Copy link
Contributor

lubird commented Oct 5, 2020 •
edited
Loading

Implement two configurable parameters:

  • Flush at: the number of items in a batch to upload (default 250)
  • Flush interval: the frequency, in seconds, to send data to Segment (default 10)

These parameters should be available when instantiating the analytics client, and they should have separate getters and setters.

Tasks:

  • Add flush at parameter
  • Add flush interval parameter
@nd4p90x nd4p90x self-assigned this Nov 1, 2020
nd4p90x added a commit to North-Two-Five/analytics-php that referenced this issue Nov 17, 2020
@nd4p90x
Issue segmentio#135:
887deb9 
add default flush_interval option in constructor and allow it to be user configurable with 1 second limit and add error message if set lower that 1.
add flush_at option and refactor batch_size option; add configurable limit to be no less that 1 and add error message if set lower that 1;
also warn user of batch_size future deprecation
@nd4p90x nd4p90x mentioned this issue Nov 17, 2020
Merged
nd4p90x added a commit to North-Two-Five/analytics-php that referenced this issue Nov 17, 2020
@nd4p90x
Merge branch 'master' into Issue-segmentio#135
aad2771
@nd4p90x nd4p90x linked a pull request Nov 17, 2020 that will close this issue
Issue #135 #148
Merged
lubird added a commit that referenced this issue Nov 24, 2020
@lubird
Merge pull request #148 from North-Two-Five/Issue-#135
3d008f6 
Issue #135
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nd4p90x nd4p90x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #135 North-Two-Five/analytics-php
2 participants
@nd4p90x @lubird