Issue #135 #148
Merged
Issue #135 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default flush_interval option in constructor and allow it to be user configurable with 1 second limit and add error message if set lower that 1. add flush_at option and refactor batch_size option; add configurable limit to be no less that 1 and add error message if set lower that 1; also warn user of batch_size future deprecation
2 tasks
lubird
approved these changes
Nov 24, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #135
add default flush_interval option in constructor and allow it to be user configurable with 1 second limit and add error message if set lower that 1.
add flush_at option and refactor batch_size option; add configurable limit to be no less that 1 and add error message if set lower that 1;
also warn user of batch_size future deprecation