-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Log errors for messages that exceed the maximum size #143
Conversation
c65d7a4
to
c2dc9a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
+ Coverage 98.38% 98.5% +0.11%
=========================================
Files 9 11 +2
Lines 371 400 +29
=========================================
+ Hits 365 394 +29
Misses 6 6
Continue to review full report at Codecov.
|
c2dc9a4
to
874c417
Compare
Note: This doesn't handle the case where a whole batch exceeds the allowed batch size: The error logged out in that case is pretty ugly. This is an error the user shouldn't have to know about - as it could be entirely handled by the library. We could split one batch into multiple that each fall under the limited size. I'll handle this in a separate PR. |
Ready for review. |
#114