Limit batch size to 500kb #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 98.76% 98.81% +0.04%
==========================================
Files 11 11
Lines 405 422 +17
==========================================
+ Hits 400 417 +17
Misses 5 5
Continue to review full report at Codecov.
|
Since builds run in parallel, the e2e tests sometimes fail because their runscope messages are pushed down by other builds. We currently test against 7 ruby versions, and a maximum of 2 builds are triggered per PR (push + PR build). Checking 20 items should be sufficient to handle this workload.
rohitpaulk
force-pushed
the
limit-batch-size
branch
from
ba8a086 to
c8cf2f1
Compare
The assertion in the thread wouldn't trigger if the test exited first.
|
Tested with the following script: require 'segment/analytics'
analytics = Segment::Analytics.new({write_key: 'testkey'})
large_message = {
properties: {a: 'b' * 30000},
user_id: 'abcd',
event: 'abcd'
}
50.times { analytics.track(large_message) }
analytics.flush(Run locally using On On this branch, the code executes successfully with no error. With some debug logs, here's how the result looks: |
|
Ready for review. Please merge #143 first though, this diff includes changes from that PR. |
rohitpaulk
force-pushed
the
limit-batch-size
branch
from
690fcea to
ffbe680
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144
Includes changes from #143.