Optimize short string parsing (part 2) #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #76 so that we check an extra 8 bytes. With #76 we only take the fast path for strings <= 7 bytes (where the quote is in the 8th byte). The fast path now covers strings of up to 15 bytes.
Parsing longer strings takes a bit of a hit, but I think overall it's a net win given the prevalence of short strings in object keys. I'm also finding that
bytes.IndexByte
is comparatively slower on arm64, so if we can avoid that with some extra bitwise operations then it's a win for our use cases.amd64:
arm64: