Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the same SWAR technique used elsewhere in the repo to check 8 bytes for the end quote in a string, before falling back to
bytes.IndexByte
:IndexByte
is pretty quick, but it still has to load the input byte into an XMM register and shuffle it around before starting the routine, and then it also has various length and CPU checks to see whether to engage AVX2 or SSE. You also have the function call overhead to consider.I think it's worth always checking the first chunk of bytes and paying the minor penalty each time you parse a string — it's common to see short strings in object keys, for example.