Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add troposphere coefficient offsets #31

Merged
merged 1 commit into from
Sep 22, 2024
Merged

add troposphere coefficient offsets #31

merged 1 commit into from
Sep 22, 2024

Conversation

semuadmin
Copy link
Contributor

pyspartn Pull Request Template

Description

  1. Fixed offsets added to troposphere attributes, in accordance with SPARTN 2.0.2 specification:

    • SF043 (Area average vertical hydrostatic delay )-> add 2.3m
    • SF045 (Small troposphere coefficient T00) -> add 0.252m
    • SF048 (Large troposphere coefficient T00) -> add 0.252m

    Thanks for @jonathanmuller for contribution.

Fixes #30

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 90% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my public domain SPARTN documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py pytest suite to maintain >= 90% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added bug Something isn't working documentation Improvements or additions to documentation labels Sep 22, 2024
@semuadmin semuadmin self-assigned this Sep 22, 2024
@semuadmin semuadmin added this to the RC 1.0.3 milestone Sep 22, 2024
@semuadmin semuadmin merged commit d4cffce into main Sep 22, 2024
5 checks passed
@semuadmin semuadmin deleted the RC-1.0.3 branch September 22, 2024 07:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant