Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow setting of maxBuffer for packing external modules (v3) #185

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Allow setting of maxBuffer for packing external modules (v3) #185

merged 2 commits into from
Aug 9, 2017

Conversation

mhodgson
Copy link
Contributor

@mhodgson mhodgson commented Aug 8, 2017

What did you implement:

Allow setting of maxBuffer for packing external modules. New version of #96

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors (not yet implemented)
  • Make sure code coverage hasn't dropped (not yet implemented)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@mhodgson mhodgson mentioned this pull request Aug 8, 2017
Closed
@HyperBrain HyperBrain merged commit 8062264 into serverless-heaven:v3.0.0 Aug 9, 2017
@HyperBrain HyperBrain added this to the 3.0.0 milestone Aug 9, 2017
@HyperBrain HyperBrain mentioned this pull request Aug 9, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mhodgson @HyperBrain