-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow setting of maxBuffer for packing external modules #96
Conversation
OK, the PR on npm-programmatic was accepted so this now uses a non-forked version. Ready to merge. |
@thenikso The other PR (Manak/npm-programmatic#8) has been merged. Think we could get this one merged soon, too? |
package.json
Outdated
@@ -31,7 +31,8 @@ | |||
"body-parser": "^1.15.2", | |||
"express": "^4.14.0", | |||
"fs-extra": "^0.26.7", | |||
"npm-programmatic": "0.0.5" | |||
"npm-programmatic": "^0.0.7", | |||
"webpack": "^1.13.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't hardcode a Webpack dependency since #83 means a user has to install Webpack as a peer dependency.
@mhodgson Can you update (rebase this PR) onto the current master? I think the issue still is present on Docker as nothing changed and the npm-programmatic version in master is still 0.0.5? @gorjuspixels Can you confirm that the issue still exists with serverless-webpack 2.2.0? |
@HyperBrain all set. |
@mhodgson Great 👍 ! I will check it out tomorrow and do some tests (with master and the 3.0.0 branch). |
Tests against master, v3.0.0 and v3.0.0-individual-packaging were successful. I also noticed a speed-up while packaging. The PR is ready to be merged -> nevertheless I will wait. Depending on the status (quality/testing) of the individual packaging branch the merge target might be the v3.0.0 branch. If everything goes well, that will be released next week. |
@mhodgson If you check the "enable edits by maintainers" checkbox in the PR, I can add some README changes to the PR and retarget it before I'll merge it next week. |
@HyperBrain checked. |
@mhodgson All v3 features are now merged into the |
@HyperBrain done: #185 |
I received the following error when trying to compile in Docker:
stderr maxBuffer exceeded
. It stems from the npm-programatic module and its use ofexec
when we install external dependencies. I have a PR opened there to add a setting for maxBuffer: Manak/npm-programmatic#8I don't recommend merging this until that PR is accepted, but I wanted to make this PR in the meantime for anyone else that runs into this problem.
This PR adds a setting called
packExternalModulesMaxBuffer
that is passed to the npmexec
for installing external dependencies.