-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use glow
instead of gl_generator
for GL/GLES bindings
#321
Conversation
glow
instead of gl_generator
for GL/GLES bindings
dce071e
to
3ae3cf7
Compare
So the problem is that: thread_local! {
pub static GL_FUNCTIONS: Gl = unsafe {Gl::from_loader_function(context::get_proc_address)};
} does not work because glow requires for context to be current, because it does some querying (version, extension). My idea is to simply replace all usages of |
Original issue about inconsistent behavior: pcwalton#7 |
I believe we could change the behavior to always make new contexts current. |
3d48909
to
df06a2e
Compare
This is very close now, macos fails due to not clearing gl error before running create surface. Needs some cleanup (warnings) and updated servo companion PR. |
If you rebase this branch on top of #326 then the crash in servo/servo#34328 will go away \o/ |
Is this ready to be reviewed now? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. I just have a few comments. In addition to what's below, please squash your changes into a single commit. Thank you!
...mple/app/src/androidTest/java/org/mozilla/surfmanthreadsexample/SurfmanInstrumentedTest.java
Outdated
Show resolved
Hide resolved
I will squash them before adding to queue. |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
See servo/servo#33539.
Note that this PR will expose glow types in surfmans public API.