fix(macOS): remove layer from superlayer when dropping #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wu Wayne <yuweiwu@pm.me>
2 tasks
You can just pin servo to new version, see #325. |
|
Ah you are right. I'll update |
jdm
approved these changes
Dec 30, 2024
This was referenced Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servo/servo#34780 's macOS smoketest failed because of double free on CALayer.
I totally forgot I had to deal with various double free issues on macOS when I attempted to make window's lifetime shorter.
Winit window will also try to free it when dropping.
Could we make a new release after this?