Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Display issues in Firefox #14

Closed
bradym opened this issue May 1, 2020 · 1 comment
Closed

Display issues in Firefox #14

bradym opened this issue May 1, 2020 · 1 comment
Assignees
@shreyasminocha
Labels
bug Something isn't working

Comments

@bradym
Copy link
Contributor

bradym commented May 1, 2020

This is a really great resource, thanks for making it available!

I'm seeing some issues on Firefox 75 on Linux (Ubuntu 18.04 to be exact).

  • Bullets for examples are not aligned with output
  • Match highlighting is not working correctly

image

This is happening throughout the site, not just in this example.
@shreyasminocha shreyasminocha added the bug Something isn't working label May 1, 2020
@shreyasminocha shreyasminocha self-assigned this May 1, 2020
shreyasminocha added a commit that referenced this issue May 2, 2020
@shreyasminocha
Fix highlights on Linux FF
d7827cd 
Addresses #14
@shreyasminocha shreyasminocha mentioned this issue May 2, 2020
Merged
@shreyasminocha shreyasminocha pinned this issue May 9, 2020
shreyasminocha added a commit that referenced this issue May 11, 2020
@shreyasminocha
Fix highlights on Linux FF
a62432d 
Addresses #14
shreyasminocha added a commit that referenced this issue May 12, 2020
@shreyasminocha
Use <mark> for match highlighting
4932741 
Aligning the ordered list of matches with character units, while novel,
was too tedious to maintain. It reportedly caused issues with some
browsers and was a nightmare to get right on mobile devices.

Resolves #5
Resolves #14
@shreyasminocha shreyasminocha unpinned this issue May 12, 2020
@bradym
Copy link
Contributor Author

bradym commented May 13, 2020

The fix looks great, thanks for your continued work on this site! It's already a great reference.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@shreyasminocha shreyasminocha

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradym @shreyasminocha