Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix match highlighting on small screens #5

Closed
shreyasminocha opened this issue Apr 26, 2020 · 2 comments · Fixed by #26
Closed

Fix match highlighting on small screens #5

shreyasminocha opened this issue Apr 26, 2020 · 2 comments · Fixed by #26
Labels
high priority

Comments

@shreyasminocha
Copy link
Owner

No description provided.

@yaches
Copy link

yaches commented May 2, 2020 •
edited by shreyasminocha
Loading

Screenshot_20200502-170336

Screenshot_20200502-165039

Screenshot_20200502-170652

Screenshot_20200502-170754

Screenshot_20200502-171228

@shreyasminocha
Copy link
Owner Author

As a temporary workaround, consider printing the single-page version to a pdf and using that.

I'll try to fix this mess.

@shreyasminocha shreyasminocha mentioned this issue May 9, 2020
Merged
shreyasminocha added a commit that referenced this issue May 11, 2020
@shreyasminocha
Minimize left margins on small screens
21a0a22 
Hot-fix for #5
shreyasminocha added a commit that referenced this issue May 11, 2020
@shreyasminocha
Allow graceful highlight wrapping
637d34d 
Addresses #5
@shreyasminocha shreyasminocha mentioned this issue May 11, 2020
Merged
2 tasks
shreyasminocha added a commit that referenced this issue May 12, 2020
@shreyasminocha
Use <mark> for match highlighting
4932741 
Aligning the ordered list of matches with character units, while novel,
was too tedious to maintain. It reportedly caused issues with some
browsers and was a nightmare to get right on mobile devices.

Resolves #5
Resolves #14
shreyasminocha added a commit that referenced this issue May 12, 2020
@shreyasminocha
Minimize left margins on small screens
7d13ca0 
Hot-fix for #5
shreyasminocha added a commit that referenced this issue May 12, 2020
@shreyasminocha
Allow graceful highlight wrapping
4b63b79 
Addresses #5
shreyasminocha added a commit that referenced this issue May 12, 2020
@shreyasminocha
Use <mark> for match highlighting
bbf01ef 
Aligning the ordered list of matches with character units, while novel,
was too tedious to maintain. It reportedly caused issues with some
browsers and was a nightmare to get right on mobile devices.

Resolves #5
Resolves #14
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix match highlighting on small screens shreyasminocha/regex-for-regular-folk
2 participants
@shreyasminocha @yaches