Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Overlayed Text #13260

Open
4 tasks done
xtrcv opened this issue Nov 16, 2023 · 0 comments
Open
4 tasks done

Overlayed Text #13260

xtrcv opened this issue Nov 16, 2023 · 0 comments

Comments

@xtrcv
Copy link

xtrcv commented Nov 16, 2023 •
edited
Loading

Bug description

Some overlayed text in the "calls" screen

Steps to reproduce

  • I go to the calls screen
    7b7781404804e1909530113a2c09e82dbdff3a9f_2_450x1000

-Pressed on one of the calls and pressed on “Select”, and then on “Select all”. Then, I long pressed on one of the calls while everything was selected and then pressed on “Info” here:

e45c1819597f47dbf25c8b9735fb250694be5316_2_450x1000

  • Then pressed here to go back:

bb802f2eba4cdb3689abf6b10e6637541c89f775_2_450x1000

  • And I saw this:
    cb77fcfda1059e5a56c8e6d2f44eda4215c98911_2_450x1000

Device info

Device: Google Pixel 6
Android version: Latest GrapheneOS, Android 14
Signal version: 6.40.4

Link to debug log

https://debuglogs.org/android/6.40.4/2c836d475a5f5929c6e8c5c7865538fba2c93537b067d89cfd8d4e6ffd3172b3
UnreachableCode added a commit to UnreachableCode/Signal-Android that referenced this issue Dec 10, 2024
@UnreachableCode
Hide default 'Signal' text when calls in call log selected
77dc980 
Fixes issue signalapp#13260 where the user would see 'Signal' with "[n] selected" in the ActionBar. 

Achieved by first hiding supportActionBar when ActionMode starts (items selected) and showing supportActionBar when it ends (all items deselected). The supportActionBar also needs to be hidden again in onResume when the user has navigated back to the screen (but only if no items are selected, using viewModel.selectionStateSnapshot.isNotEmpty(...).
@UnreachableCode UnreachableCode mentioned this issue Dec 10, 2024
Open
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xtrcv