Hide default 'Signal' text when calls in call log selected #13834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue signalapp#13260 where the user would see 'Signal' with "[n] selected" in the ActionBar. Achieved by first hiding supportActionBar when ActionMode starts (items selected) and showing supportActionBar when it ends (all items deselected). The supportActionBar also needs to be hidden again in onResume when the user has navigated back to the screen (but only if no items are selected, using viewModel.selectionStateSnapshot.isNotEmpty(...).
Tested this and realized hide only needs to be called in onResume().
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13260 where the user would see 'Signal' with "[n] selected" in the ActionBar.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Fixed the overlapping text issue that @xtrcv demonstrated.
Achieved by first hiding supportActionBar when ActionMode starts (items selected) and showing supportActionBar when it ends (all items deselected). The supportActionBar also needs to be hidden again in onResume when the user has navigated back to the screen (but only if no items are selected, using viewModel.selectionStateSnapshot.isNotEmpty(...).
I ran gradlw format with no relevant issues.
Video of manual test:
https://github.com/user-attachments/assets/319f01e5-ffa5-4187-aecf-93b5e314f9d3