Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Begin an examples/ directory #108

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Begin an examples/ directory #108

merged 7 commits into from
Aug 2, 2022

Conversation

jdolitsky
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #108 (d8a0da3) into main (a9683bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   63.36%   63.36%           
=======================================
  Files          26       26           
  Lines        2301     2301           
=======================================
  Hits         1458     1458           
  Misses        770      770           
  Partials       73       73           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@vaikas
Copy link
Collaborator

vaikas commented Jul 27, 2022

This is a great start. My original thinking was that these would live somewhere that we could also run tests against them. Here's couple of them:
https://github.com/sigstore/policy-controller/tree/main/test/testdata/policies

I think that having examples is more discoverable name for sure, but I'd also like to add tests to make sure that we don't break examples for folks. WDYT?

@vaikas
Copy link
Collaborator

vaikas commented Jul 27, 2022

Sorry (point about them being discoverable ;) ), here:

https://github.com/sigstore/policy-controller/tree/main/test/testdata/policy-controller/e2e

@jdolitsky jdolitsky force-pushed the examples branch 12 times, most recently from 83ede40 to 31fbb88 Compare July 28, 2022 16:41
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky force-pushed the examples branch 2 times, most recently from 7213d12 to 0010029 Compare July 28, 2022 17:06
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Contributor Author

Since the example is using keyless fulcio sig, I've set it to run only on push to main

For other examples (using custom keypair), we could run the in PRs

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
…mples

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Contributor Author

mergarooski?

@vaikas vaikas merged commit 61447e8 into sigstore:main Aug 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants