-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Begin an examples/ directory #108
Conversation
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 63.36% 63.36%
=======================================
Files 26 26
Lines 2301 2301
=======================================
Hits 1458 1458
Misses 770 770
Partials 73 73 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
This is a great start. My original thinking was that these would live somewhere that we could also run tests against them. Here's couple of them: I think that having examples is more discoverable name for sure, but I'd also like to add tests to make sure that we don't break examples for folks. WDYT? |
Sorry (point about them being discoverable ;) ), here: https://github.com/sigstore/policy-controller/tree/main/test/testdata/policy-controller/e2e |
83ede40
to
31fbb88
Compare
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
7213d12
to
0010029
Compare
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Since the example is using keyless fulcio sig, I've set it to run only on push to main For other examples (using custom keypair), we could run the in PRs |
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
…mples Signed-off-by: Josh Dolitsky <josh@dolit.ski>
mergarooski? |
No description provided.