Fix keyful handling in tester. #115
Merged
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
@jdolitsky found in #108 that the tester was not handling the Keyful validation correctly. This was caused by us not 'round-tripping' the webhook cip, which in the Policy-Controller path is marshalled by the reconciler and unmarshalled before handing to the validator path. One thing the unmarshaller does is convert the inlined data blocks into crypto keys which is what the policy-controller validator uses.
So, this PR adds that round tripping before using the webhook cip.
Release Note
Documentation