Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FIX Use PHP 8.3 #47

Merged
merged 1 commit into from
Dec 10, 2024
Merged

FIX Use PHP 8.3 #47

merged 1 commit into from
Dec 10, 2024

Conversation

emteknetnz
Copy link
Member

Issue #46

@emteknetnz emteknetnz mentioned this pull request Dec 10, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review December 10, 2024 03:37
@emteknetnz emteknetnz mentioned this pull request Dec 10, 2024
Merged
GuySartorelli
GuySartorelli approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shouldn't have any conflicts with CMS 4 since we're not actually trying to run a cms project.

@GuySartorelli GuySartorelli merged commit e9d98df into silverstripe:1.2 Dec 10, 2024
2 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.2/php83 branch December 10, 2024 20:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli