API Rename validator classes #355
Merged
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
937c5c2 to
cca47b1
Compare
8 tasks
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
cca47b1 to
56f6920
Compare
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
56f6920 to
906841c
Compare
GuySartorelli
approved these changes
Dec 9, 2024
|
CI is failing with Can you please investigate whether that's a legitimate issue or if CI is just having caching trouble or similar? |
emteknetnz
force-pushed
the
pulls/5/valid
branch
3 times, most recently
from
44403e4 to
528cdec
Compare
|
I've updated the require-dev dep of elemental from ^6 to 6.x-dev, because it is currently just installing 6.0.0-alpha1. Alternative would be to manually release 6.0.0-alpha2. However I need to merge up elemental since the latest code went to 6.0.x-dev though cannot do that via github actions until this PR is merged silverstripe/gha-merge-up#47 |
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
528cdec to
0fe20c5
Compare
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
0fe20c5 to
1f6cf62
Compare
GuySartorelli
approved these changes
Dec 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10908