NEW Add paginator component #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/3.0/paginator
branch
3 times, most recently
from
ed1880f to
aae7113
Compare
GuySartorelli
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Not clear whether silverstripe/silverstripe-versioned-admin#391 (review) will require changes here so I'll hold off approving
|
Where is |
emteknetnz
commented
Mar 4, 2025
| @@ -0,0 +1,86 @@ | |||
| .paginator-footer > div { | |||
There was a problem hiding this comment.
emteknetnz
force-pushed
the
pulls/3.0/paginator
branch
from
aae7113 to
eb70137
Compare
It's the default view in asset-admin i.e. large thumbnails, as opposed to the TableView which you toggle to |
emteknetnz
force-pushed
the
pulls/3.0/paginator
branch
from
eb70137 to
765996d
Compare
|
Oop looks like new conflicts 😅 |
emteknetnz
force-pushed
the
pulls/3.0/paginator
branch
from
765996d to
7e7c561
Compare
GuySartorelli
approved these changes
Mar 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1892
This component replaces the Griddle paginator that was used for paginating results in the following places: