ENH Replace griddle with Paginator component #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/3.0/react-table
branch
from
c74dc54 to
52ba384
Compare
GuySartorelli
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Compare mode doesn't work
- Click the weird settings button in the top right
- Check the "compare two versions" checkbox
- Select any two versions (you can select across pages but you don't have to)
- After selecting the second one, the comparison content doesn't load and an error is in the console
|
Works fine on my setup, including if I compare across paginated results i.e. one version of page one and another on page 2 (I've set Are you sure you also have the silverstripe/silverstripe-admin#1909 PR installed? |
|
I definitely had it installed - but pulling the latest changes from that PR has resolved whatever was going wrong. |
emteknetnz
force-pushed
the
pulls/3.0/react-table
branch
from
52ba384 to
0a13837
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1892