[Core] Enable use docker image w/ non-default entrypoint as runtime env #3867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the docker image had an entry point that was not default (
/bin/bash
), it would fail when running as runtime env on real clouds (in k8s it works since we have special handling for this), e.g. the vllm official docker usespython3 -m vllm.entrypoints.openai.api_server
as entry point, as ref here: https://github.com/vllm-project/vllm/blob/9db93de20ca282feb4dfaabbc56032c9312bde7b/Dockerfile#L222This PR fixed it by overriding the entry point to
/bin/bash
.Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_docker_storage_mounts
pytest tests/test_smoke.py::test_job_queue_with_docker
pytest tests/test_smoke.py::test_docker_preinstalled_package
conda deactivate; bash -i tests/backward_compatibility_tests.sh