Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Core] Enable use docker image w/ non-default entrypoint as runtime env #3867

Merged
merged 5 commits into from
Aug 27, 2024
Merged

[Core] Enable use docker image w/ non-default entrypoint as runtime env #3867

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ede2db9
fix
cblmemo Aug 21, 2024
24cf958
fix in cmd runner as well
cblmemo Aug 23, 2024
94803dc
add comment in docs
cblmemo Aug 26, 2024
cf73a52
revert unwanted changes
cblmemo Aug 26, 2024
eaf6dfd
add runpod explanation
cblmemo Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/provision/docker_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ def docker_start_cmds(
'--cap-add=SYS_ADMIN',
'--device=/dev/fuse',
'--security-opt=apparmor:unconfined',
'--entrypoint=/bin/bash',
image,
'bash',
]
return ' '.join(docker_run)

Expand Down
2 changes: 1 addition & 1 deletion sky/skylet/providers/command_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ def docker_start_cmds(
'--cap-add=SYS_ADMIN',
'--device=/dev/fuse',
'--security-opt=apparmor:unconfined',
'--entrypoint=/bin/bash',
image,
'bash',
]
return ' '.join(docker_run)

Expand Down
Loading