FIX: Small change to addess a valueError in PyDMSlider when they are being dragged #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o prevent a value error
pydm/widgets/slider.py
Outdated
| @@ -78,9 +78,9 @@ def mouseMoveEvent(self, event): | |||
| delta = event.pos() - self.dragStartPos | |||
|
|
|||
| if self.orientation() == Qt.Horizontal: | |||
| delta_value = (delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()) | |||
| delta_value = int(round((delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()))) | |||
There was a problem hiding this comment.
do we need both round and then int cast?
There was a problem hiding this comment.
It looks like not, I thought round would return a float if given a float, but it looks like without a ndigits passed it returns an int. I will remove the int casting
nstelter-slac
approved these changes
Jan 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a value error can be thrown when dragging the handle of a slider that has floating point values. This fix rounds and casts to int the value change while dragging the handle of the PyDMSlider