Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Small change to addess a valueError in PyDMSlider when they are being dragged #1147

Merged
merged 2 commits into from
Jan 14, 2025
+2 −3
Merged

FIX: Small change to addess a valueError in PyDMSlider when they are being dragged #1147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696c303
round and cast to int every change while dragging the slider handle t…
YektaY Dec 20, 2024
69adcfb
removed int casting
YektaY Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pydm/widgets/slider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,9 @@ def mouseMoveEvent(self, event):
delta = event.pos() - self.dragStartPos

if self.orientation() == Qt.Horizontal:
delta_value = (delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum())
delta_value = round((delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()))
else:
delta_value = (-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum())

delta_value = round((-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum()))
new_value = self.dragStartValue + delta_value
new_value = min(max(self.minimum(), new_value), self.maximum())
self.setValue(new_value)
Expand Down
Loading