Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the behavior of links in comments, releases etc. in several ways:
URLSpan
behavior).This avoids the need to set OctoDroid as the default handler for GitHub links, in order to prevent the Android "Open with..." sheet from showing up every time.
An alternative solution could be to open all links in custom tabs by default and add an option to toggle this behavior. I'm not sure on which of the two solutions is best.
I've also added a missing
<queries>
intent filter needed to be able to detect which browser support custom tabs on Android 11+.Implementation note: the refactoring in d2dd3e8 was done in order to be able to execute the
loadTask
inLinkSpan
, without closing the activity in which the link was clicked.