Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes for link handling regressions #1133

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Nov 5, 2021

This PR fixes a couple of regressions introduced by #1118:

  • many non-GitHub links erroneously resolved to OctoDroid activities, because the LinkParser didn't take into account the possibility of receiving non-GitHub URLs
  • tapping on links to relative URLs (such as anchor links in Readme) made the app crash due to an NPE
  • when an URL couldn't be resolved to an OctoDroid activity, it wasn't opened in the browser as it should have been

Also, tests didn't compile until I fixed them. Ideally there should be a pipeline that builds the app and runs them, so that at least they have a chance to run from time to time :)

@Fs00
Copy link
Contributor Author

Fs00 commented Nov 5, 2021

Update: I've found another regression, I'll look into fixing it tomorrow.

@maniac103
Copy link
Collaborator

Let me guess: links to external URLs being broken, like your video in #1131? If not, I'd like to mention that one as well ;-) I unfortunately haven't had time to debug that one yet.

@Fs00
Copy link
Contributor Author

Fs00 commented Nov 5, 2021

Let me guess: links to external URLs being broken

Nope! That one has been fixed in 07ba31b, hasn't it?
It's a more hidden and subtle issue, you'll see it tomorrow 😉

Don't assume it was set in the activity's launch intent
@Fs00
Copy link
Contributor Author

Fs00 commented Nov 6, 2021

Pushed the fix for the extra regression (I've added it to the PR description).
You could experience the regression when tapping on "Roadmap" and "Releases" links in this README.

@maniac103 maniac103 merged commit c043714 into slapperwan:master Nov 12, 2021
@Fs00 Fs00 deleted the link-fixes branch November 12, 2021 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants