-
Notifications
You must be signed in to change notification settings - Fork 85
feat: make kernels an enum that implements kernel #181
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
7df774d
to
a753248
Compare
c96821d
to
a753248
Compare
7b7dedf
to
5e9be36
Compare
Codecov Report
@@ Coverage Diff @@
## development #181 +/- ##
===============================================
+ Coverage 84.58% 84.69% +0.10%
===============================================
Files 86 86
Lines 9974 9998 +24
===============================================
+ Hits 8437 8468 +31
+ Misses 1537 1530 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@morenol is this still a draft? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflict with new code in development
I think that now that Kernel trait is object safe we can just use #228 approach instead |
Fixes #
Checklist
Current behaviour
New expected behaviour
Change logs