Skip to content

feat: make kernels an enum that implements kernel #181

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from

Conversation

morenol
Copy link
Collaborator

@morenol morenol commented Oct 1, 2022

Fixes #

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

New expected behaviour

Change logs

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #181 (5e9be36) into development (f8210d0) will increase coverage by 0.10%.
The diff coverage is 90.24%.

@@               Coverage Diff               @@
##           development     #181      +/-   ##
===============================================
+ Coverage        84.58%   84.69%   +0.10%     
===============================================
  Files               86       86              
  Lines             9974     9998      +24     
===============================================
+ Hits              8437     8468      +31     
+ Misses            1537     1530       -7     
Impacted Files Coverage Δ
src/model_selection/kfold.rs 88.99% <ø> (ø)
src/model_selection/mod.rs 94.04% <ø> (ø)
src/svm/mod.rs 79.24% <77.77%> (-7.25%) ⬇️
src/model_selection/hyper_tuning/grid_search.rs 81.03% <100.00%> (+3.48%) ⬆️
src/svm/svc.rs 89.94% <100.00%> (+2.23%) ⬆️
src/svm/svr.rs 86.56% <100.00%> (+0.37%) ⬆️
src/metrics/mod.rs 32.43% <0.00%> (+8.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Oct 17, 2022

@morenol is this still a draft?

@morenol morenol marked this pull request as ready for review October 17, 2022 13:11
@morenol morenol requested a review from Mec-iS as a code owner October 17, 2022 13:11
@Mec-iS Mec-iS requested a review from montanalow October 17, 2022 13:34
@Mec-iS
Copy link
Collaborator

Mec-iS commented Oct 18, 2022

This looks great though it would be better imo to have this to be merged directly in branch v0.5-wip as model_selection is already been ported. What do you thing @morenol ?
Could something similar to this also facilitate the porting of src/ensemble (see this comment)?

Copy link
Collaborator

@Mec-iS Mec-iS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict with new code in development

@morenol
Copy link
Collaborator Author

morenol commented Nov 3, 2022

I think that now that Kernel trait is object safe we can just use #228 approach instead

@morenol morenol closed this Nov 3, 2022
@morenol morenol deleted the lmm/kernels_enum branch November 4, 2022 22:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants