-
Notifications
You must be signed in to change notification settings - Fork 85
Use Box in SVM and remove lifetimes #228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
i like the idea of making the kernels name with static lifetime but we cannot use Box for the kernel as it ruins the API call. For an example of how kernels are used see the Jupyter notebooks:
how the kernels are used in tests is irrelevant. we don't want the end-users to allocate to the heap manually. |
about implementing an enum for kernels, see #221 |
22d9f44
to
89d2bbb
Compare
|
Good one! |
* Do not change external API Authored-by: Luis Moreno <morenol@users.noreply.github.com>
Fixes #
Checklist
Current behaviour
New expected behaviour
Change logs