Feature/new remote control modules #2077

LuxoftAKutsan · 2018-03-21T14:55:04Z

Implements #1798 #1930 #1860

This PR is ready for review.

Risk

This PR makes major API changes.

Testing Plan

Tested with ATF : https://github.com/smartdevicelink/sdl_atf
Used ATF scripts from : smartdevicelink/sdl_atf_test_scripts#1854

Manual testing:

Used HMI from : smartdevicelink/sdl_hmi#52
Used mobile application SPT from HockeyApp 20180213-Nightly-Android

Summary

Implements proposals Proposals:
0099-new-remote-control-modules-and-parameters
0105-remote-control-seat
0106-remote-control-onRcStatus-notification

Other parts of delivery :

CI activities : http://opensdl-jenkins.luxoft.com:8080/view/New_remote_control_modules/
Architecture changes : RPC design refactoring sdl_core_documentation#10
HMI Integration guidelines : Common, Enum index was updated with new params. OnRCStatus was created sdl_hmi_integration_guidelines#91
SDL requirements : Feature/new rc modules sdl_requirements#55
ATF scripts : Scripts for feature "New Remote Control modules" sdl_atf_test_scripts#1854
HMI : Feature/new remote control modules sdl_hmi#52

CLA

[x ] I have signed the CLA

Fix commands UTs

Fix tests Fix due to rebase Fix unit tests in mobile commands Fixed unit tests in next commands: - delete_command_request_test.cc - delete_sub_menu_test.cc - perform_audio_pass_thru_test.cc - reset_global_properties_test.cc - send_location_request_test.cc - set_global_properties_test.cc

Fix SendAudioPassThroughNotification Rename Command Origin to Command Source

add Optional type Fix compile warnings and use optional for returning plugin Add descriptions to optional Fix review issues Fix header guards Fix build with unit tests after commands factory refactoring - Change enum name from command origin to command source - Create Mock for command factory class - Fix mock_app_manager after refactoring - Fix failed unit test

Remove commands includes Remove commands includes

Replace include path of the commands Fix some things Fixing compile of applicaiton manager Move Commands interface part back to application_manager Use unique ptr for plugin manager Fix style in RPC services and factories Remove redunsant includes of factories in application manager Remove include of functional module

cory library to install dir Fix build Fix header guards Fix namespaces Fix build

Move notification and command implementation back to applicaiton manager Copywriting added. In 'src/components/application_manager/rpc_plugins/sdl_rpc_plugin/' folder added copywriting for next files: include/sdl_rpc_plugin/sdl_rpc_plugin.h src/commands/hmi/navi_stop_stream_request.cc src/commands/hmi/on_tts_reset_timeout_notification.cc src/commands/mobile/get_system_capability_request.cc src/commands/mobile/get_system_capability_response.cc src/commands/mobile/get_way_points_request.cc src/commands/mobile/get_way_points_response.cc src/commands/mobile/subscribe_way_points_request.cc src/commands/mobile/subscribe_way_points_response.cc src/commands/mobile/unsubscribe_way_points_request.cc src/commands/mobile/unsubscribe_way_points_response.cc src/sdl_rpc_plugin.cc

In CommandImpl added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed constructors CommandImpl, CommandRequestImpl and CommandResponseImpl.

In all mobile command added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed all constructors.

In all hmi command added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed all constructors.

Replaced all usages of passed parameters in implementation from application manager proxy to indirect call Add missed factories Remove commands includes

- Change enum name from command origin to command source - Create Mock for command factory class - Fix mock_app_manager after refactoring - Fix failed unit test Fix unit test in progress Add asser in plugin manager getter Fixed UT Application manager impl -Add method "SetRPCService" into the class ApplicationManagerImpl Fixed UT Application manager impl -Add method "SetRPCService" into the class ApplicationManagerImpl Fixed UT Application manager impl -Add method "SetRPCService" into the class ApplicationManagerImpl Fixed UTs for hmi and mobile commands.

Add app extension Add reaction on App registraion fix notofying plugins about app registrtion

Implementation of resource allocaiton manager Resource allocation manager tests Fix unit test fo RA Add logger in unit test target to have ability analyze unit tests run without debug Init logger in tests

yang1070 · 2018-04-16T13:06:25Z

...on_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_driver_distraction_notification.cc

@@ -0,0 +1,143 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:07:52Z

...ication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_event_changed_notification.cc

@@ -0,0 +1,64 @@
+/*
+ * Copyright (c) 2015, Ford Motor Company


yang1070 · 2018-04-16T13:08:31Z

...manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_exit_all_applications_notification.cc

@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) 2014, Ford Motor Company


yang1070 · 2018-04-16T13:10:28Z

...tion_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_exit_application_notification.cc

@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 2017, Ford Motor Company


yang1070 · 2018-04-16T13:11:29Z

...lication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_file_removed_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:12:03Z

...ents/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_find_applications.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:13:08Z

...ents/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_find_applications.cc

+void OnFindApplications::Run() {
+  LOG4CXX_AUTO_TRACE(logger_);
+
+  // TODO(PV): add UpdateAppsOnDevice to ApplicationManager


// TODO(PV): add UpdateAppsOnDevice to ApplicationManager
is this finished yet?

yang1070 · 2018-04-16T13:13:26Z

...n_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_ignition_cycle_over_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:14:02Z

...manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_navi_tbt_client_state_notification.cc

@@ -0,0 +1,67 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:14:48Z

...manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_navi_way_point_change_notification.cc

@@ -0,0 +1,63 @@
+/*
+ * Copyright (c) 2015, Ford Motor Company


yang1070 · 2018-04-16T13:15:33Z

...mponents/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_policy_update.cc

@@ -0,0 +1,60 @@
+/*
+ * Copyright (c) 2014, Ford Motor Company


yang1070 · 2018-04-16T13:16:24Z

.../application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_put_file_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:17:27Z

...nts/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_ready_notification.cc

@@ -0,0 +1,65 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:18:17Z

...application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_received_policy_update.cc

@@ -0,0 +1,77 @@
+/*
+ * Copyright (c) 2016, Ford Motor Company


yang1070 · 2018-04-16T13:19:51Z

...lication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_record_start_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:20:54Z

...n_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_resume_audio_source_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2014, Ford Motor Company


yang1070 · 2018-04-16T13:21:27Z

...application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_sdl_close_notification.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:21:58Z

...on_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_sdl_consent_needed_notification.cc

@@ -0,0 +1,62 @@
+
+/**
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:22:34Z

...ager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_sdl_persistence_complete_notification.cc

@@ -0,0 +1,61 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:23:08Z

...application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_start_device_discovery.cc

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:23:49Z

...ication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_status_update_notification.cc

@@ -0,0 +1,61 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:24:18Z

...cation_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_system_context_notification.cc

@@ -0,0 +1,88 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:26:42Z

...lication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_system_error_notification.cc

@@ -0,0 +1,67 @@
+/*
+ * Copyright (c) 2014, Ford Motor Company


yang1070 · 2018-04-16T13:27:30Z

...n_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_system_info_changed_notification.cc

@@ -0,0 +1,69 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:28:37Z

...cation_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_system_request_notification.cc

@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


yang1070 · 2018-04-16T13:33:13Z

...n_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_tts_language_change_notification.cc

@@ -0,0 +1,103 @@
+/*
+ * Copyright (c) 2013, Ford Motor Company


LuxoftAKutsan · 2018-06-20T13:49:41Z

Not actual. Spitted to
#2250
#2207
#2208
#2209

This was referenced Mar 21, 2018

RPC design refactoring smartdevicelink/sdl_core_documentation#10

Merged

Scripts for feature "New Remote Control modules" smartdevicelink/sdl_atf_test_scripts#1854

Closed

KhrystynaDubovyk mentioned this pull request Mar 21, 2018

Common, Enum index was updated with new params. OnRCStatus was created. smartdevicelink/sdl_hmi_integration_guidelines#90

Merged

LuxoftAKutsan mentioned this pull request Mar 21, 2018

Feature/new rc modules smartdevicelink/sdl_requirements#55

Closed

AStasiuk requested review from mrapitis, yang1070 and robinmk March 22, 2018 13:05

LitvinenkoIra force-pushed the feature/new_remote_control_modules branch from 9ef7a64 to 4b069f0 Compare March 22, 2018 13:06

jacobkeeler added the proposal Accepted SDL Evolution Proposal label Mar 23, 2018

Ira Lytvynenko and others added 21 commits April 4, 2018 14:13

RPCService implementation

6f76e26

Fix commands UTs

Refactor CommandFactory

0c7f81b

Fix SendAudioPassThroughNotification Rename Command Origin to Command Source

Move commands to sdl rpc plugin

ed91ff1

SDL RPC plugin CMAKElist

c4d8943

Remove all remote controll

e3ca01a

Remove commands includes Remove commands includes

Folder structure for rc_rpc_plugin

a0476fd

Load plugins in app manager, init plugin with params

30bc88c

cory library to install dir Fix build Fix header guards Fix namespaces Fix build

Refactoring CommandImpl, CommandRequestImpl and CommandResponseImpl

5524cbd

In CommandImpl added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed constructors CommandImpl, CommandRequestImpl and CommandResponseImpl.

Refactoring all mobile commands.

4b9fede

In all mobile command added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed all constructors.

Refactoring all hmi commands.

180d8be

In all hmi command added rpc_service_, hmi_capabilities_ and policy_handler_ fields. Also changed all constructors.

Replaced all usages of passed parameters in implementation.

0b73356

Replaced all usages of passed parameters in implementation from application manager proxy to indirect call Add missed factories Remove commands includes

Add header stubs for RC plugin

b18c194

Add source files for rc commands and fix some sdl commands

374d1c4

Add initial impl for rc command factory and fix some rc commands

b2834b5

Add app extension Add reaction on App registraion fix notofying plugins about app registrtion

RC Command Factory implementation

9718ca2

Add Resource allocation manager stub

ee8d7d4

Implementation of resource allocaiton manager Resource allocation manager tests Fix unit test fo RA Add logger in unit test target to have ability analyze unit tests run without debug Init logger in tests

yang1070 reviewed Apr 16, 2018

View reviewed changes

LuxoftAKutsan mentioned this pull request May 3, 2018

[Accepted with Revisions] SDL 0168 - RPC design refactoring smartdevicelink/sdl_evolution#486

Closed

LuxoftAKutsan closed this Jun 20, 2018

jacobkeeler deleted the feature/new_remote_control_modules branch June 9, 2020 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/new remote control modules #2077

Feature/new remote control modules #2077

LuxoftAKutsan commented Mar 21, 2018 •

edited

Loading

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

yang1070 Apr 16, 2018

LuxoftAKutsan commented Jun 20, 2018

Feature/new remote control modules #2077

Feature/new remote control modules #2077

Conversation

LuxoftAKutsan commented Mar 21, 2018 • edited Loading

Risk

Testing Plan

Manual testing:

Summary

CLA

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuxoftAKutsan commented Jun 20, 2018

LuxoftAKutsan commented Mar 21, 2018 •

edited

Loading