Feature/RC SEAT #2208
Merged
Feature/RC SEAT #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSolonenko
force-pushed
the
feature/rc_refactoring
branch
2 times, most recently
from
4a97805 to
4ce2e58
Compare
LitvinenkoIra
force-pushed
the
feature/rc_refactoring
branch
from
4ce2e58 to
379e61b
Compare
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
d2a9677 to
baddd19
Compare
yang1070
reviewed
May 29, 2018
| for (const auto& param : params) { | ||
| if (param.first == module_type) { | ||
| if (rc_capabilities.keyExists(param.second)) { | ||
| is_module_type_valid = true; |
There was a problem hiding this comment.
add a break; after set is_module_type_valid = true?
yang1070
reviewed
May 29, 2018
| bool module_type_and_data_match = false; | ||
| for (const auto& data : data_mapping) { | ||
| if (data.first == module_type) { | ||
| module_type_and_data_match = module_data.keyExists(data.second); |
yang1070
reviewed
May 29, 2018
| @@ -1224,6 +1224,9 @@ | |||
| </element> | |||
| <element name="MOBILE_APP"> | |||
| </element> | |||
| <element name="RADIO_TUNER"> | |||
There was a problem hiding this comment.
this does not relate to SEAT, please remove from this PR
yang1070
reviewed
May 29, 2018
| @@ -469,6 +469,25 @@ | |||
| "signalStrengthAvailable": true, | |||
| "stateAvailable": true | |||
| } | |||
| ], | |||
| "seatControlCapabilities": [ | |||
There was a problem hiding this comment.
missing moduleName
"moduleName" : "driver seat"
or "moduleName" : "DRIVER"
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
baddd19 to
dbf88ad
Compare
LitvinenkoIra
force-pushed
the
feature/rc_refactoring
branch
from
72cc17e to
6f85170
Compare
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
dbf88ad to
c92e0f6
Compare
|
@theresalech Ford has reviewed, tested and approved this PR, It is ready for Livio to review. |
ghost
force-pushed
the
feature/rc_refactoring
branch
from
6f85170 to
56c61b1
Compare
LitvinenkoIra
force-pushed
the
feature/rc_refactoring
branch
from
56c61b1 to
ba8f7c0
Compare
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
c92e0f6 to
32bf158
Compare
LitvinenkoIra
force-pushed
the
feature/rc_refactoring
branch
from
ba8f7c0 to
1faf0e3
Compare
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
32bf158 to
19eadf4
Compare
This was referenced Jun 20, 2018
|
@theresalech @LuxoftAKutsan |
LitvinenkoIra
changed the base branch from
feature/rc_refactoring
to
feature/vehicle_info_plugin
LitvinenkoIra
force-pushed
the
feature/vehicle_info_plugin
branch
from
b558a9f to
22d3d2e
Compare
LitvinenkoIra
force-pushed
the
feature/rc_seat
branch
from
19eadf4 to
0283a85
Compare
This was referenced Jun 27, 2018
Closed
LuxoftAKutsan
changed the base branch from
feature/vehicle_info_plugin
to
develop
Jack-Byrne
approved these changes
Jul 13, 2018
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based on RPC design refactoring, so this PR should be merged after #2250
Technical task : #1860
This PR is ready for review.
This pull request contains the implementation of new remote control module - SEAT
(proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0105-remote-control-seat.md)
For testing use the following test set:
https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/feature/rc_seat/test_sets/rc_SEAT.txt
Pull request with ATF scripts: smartdevicelink/sdl_atf_test_scripts#1910
For manual testing use:
HMI from : smartdevicelink/sdl_hmi#52
mobile application SPT from HockeyApp 20180213-Nightly-Android
Risk
This PR makes [major] API changes.
CLA