Initial implementation of expanded mobile PutFile #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AByzhynar
requested review from
AKalinich-Luxoft,
LuxoftAKutsan,
LitvinenkoIra,
aderiabin,
EKuliiev,
KVGrygoriev and
KhrystynaDubovyk
AByzhynar
force-pushed
the
feature/expand_put_file
branch
from
4bc4914 to
be246ef
Compare
AByzhynar
force-pushed
the
feature/expand_put_file
branch
from
05df881 to
ecb4f36
Compare
AByzhynar
force-pushed
the
feature/expand_put_file
branch
from
be246ef to
4bc4914
Compare
LuxoftAKutsan
suggested changes
Apr 12, 2018
| namespace { | ||
|
|
||
| uint32_t GetCrc32CheckSum(const std::vector<uint8_t>& binary_data) { | ||
| std::size_t file_size = binary_data.size(); |
There was a problem hiding this comment.
@AByzhynar const variable
There was a problem hiding this comment.
@LuxoftAKutsan Fixed in 9e46887
|
|
||
| namespace { | ||
|
|
||
| uint32_t GetCrc32CheckSum(const std::vector<uint8_t>& binary_data) { |
There was a problem hiding this comment.
@AByzhynar documentation would be nice
There was a problem hiding this comment.
@LuxoftAKutsan Fixed in 9e46887
| const size_t bin_data_size = binary_data.size(); | ||
|
|
||
| if ((*message_)[strings::msg_params].keyExists(strings::crc32_check_sum)) { | ||
| LOG4CXX_DEBUG(logger_, "Binary Data Size: " << bin_data_size); |
There was a problem hiding this comment.
@AByzhynar make it tace
There was a problem hiding this comment.
@LuxoftAKutsan Fixed in 9e46887
KVGrygoriev
approved these changes
Apr 12, 2018
EKuliiev
approved these changes
Apr 13, 2018
LuxoftAKutsan
approved these changes
Apr 13, 2018
AByzhynar
force-pushed
the
feature/expand_put_file
branch
from
9e46887 to
e55964f
Compare
Implemented function in PutFile which correctly calculates CRC32 checksum for std::vector<uint8_t> Added comparison of calculated CRC checksum with received in PutFile request. Added PutFile response generation in case of CRC sum mismatch Fixed handling of unsigned integer values
AByzhynar
force-pushed
the
feature/expand_put_file
branch
from
e55964f to
97e267a
Compare
BSolonenko
approved these changes
Apr 13, 2018
KhrystynaDubovyk
approved these changes
Apr 13, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1455
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
ATF tests scripts will be provided
Summary
Implemented function in PutFile which correctly calculates CRC32 checksum
Added comparison of calculated CRC checksum with received in PutFile
request.
Added PutFile response generation in case of CRC sum mismatch
Fixed handling of unsigned integer values
Tasks Remaining:
CLA