Implementation of Expandable design for proprietary data exchange feature #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change name systemRequest Label Bugfix error at the ffw/BasicCommunication OnSystemRequest method with subType parameter which was null and which was calling. Change name systemRequest Label from 'System request' to 'requestSubType'.
…oprietary_data_exchange Bugfix error at the OnSystemRequest method and
…roprietary_data_exchange Implementation of Expandable design for proprietary data exchange feature
yang1070
approved these changes
May 18, 2018
jacobkeeler
requested changes
May 31, 2018
ffw/BasicCommunicationRPC.js
Outdated
| @@ -1149,6 +1149,14 @@ FFW.BasicCommunication = FFW.RPCObserver | |||
| if (appID) { | |||
| JSONMessage.params.appID = appID; | |||
| } | |||
| if(subType && subType.length > 0){ | |||
There was a problem hiding this comment.
@jacobkeeler fixed in 4428727
css/sdl.css
Outdated
| @@ -827,6 +834,11 @@ | |||
| top: 180px; | |||
| } | |||
|
|
|||
| #systemRequestView .requestSubTypeInput { | |||
| top: 217px; | |||
|
|
|||
There was a problem hiding this comment.
@jacobkeeler fixed in 4428727
jacobkeeler
requested changes
Jun 6, 2018
ffw/BasicCommunicationRPC.js
Outdated
| if (subType && subType.length > 0) { | ||
| if (type == 'OEM_SPECIFIC'|| | ||
| type == 'HTTP'|| | ||
| type == 'PROPRIETARY') { |
There was a problem hiding this comment.
Shouldn't need this restriction. The only cases where subType shouldn't be used are existing PTU Requests (HTTP request w/ BINARY fileType or PROPRIETARY request w/ JSON fileType): https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0083-Expandable-design-for-proprietary-data-exchange.md#impact-on-existing-code
There was a problem hiding this comment.
@jacobkeeler good catch, thanks.
Fixed in 3003881
jacobkeeler
approved these changes
Jun 8, 2018
Merged
jacobkeeler
deleted the
feature/expandable_design_for_proprietary_data_exchange
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes smartdevicelink/sdl_core#1734
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
HMI behavior should be tested manually
Summary
Made the following changes:
CLA