Merge pull request #561 from snyk/fix/wrong-dispatcher-reqs-with-latency

fix: properly structure qs params in dispatcher calls
snyk · Jun 5, 2023 · 9169dec · 9169dec
2 parents a9f89b4 + 5556117
commit 9169dec
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/lib/dispatcher.js b/lib/dispatcher.js
@@ -49,17 +49,22 @@ class DispatcherClient {
     time = -1,
   ) {
     const hashedToken = hashToken(token);
-    let queryStringParams = clientId
-      ? `?broker_client_id=${clientId}&request_type=${requestType}`
-      : '';
+    const url = new URL(
+      `${this.#url}/internal/brokerservers/${
+        this.#id
+      }/connections/${hashedToken}`,
+    );
+    if (clientId) {
+      url.searchParams.append('broker_client_id', clientId);
+    }
     if (time != -1) {
-      queryStringParams = queryStringParams + `&latency=${Date.now() - time}`;
+      url.searchParams.append('latency', Date.now() - time);
     }
+    url.searchParams.append('request_type', requestType);
+
     await this.#makeRequest(
       { hashedToken, clientId, requestType: requestType },
-      `${this.#url}/internal/brokerservers/${
-        this.#id
-      }/connections/${hashedToken}${queryStringParams}`,
+      url.toString(),
       'post',
       {
         data: {