Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[request] checkServerIdentity option #615

Closed
djgorilla opened this issue Jul 30, 2019 · 3 comments
Closed

[request] checkServerIdentity option #615

djgorilla opened this issue Jul 30, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@djgorilla
Copy link

[x] request a feature

allow checkServerIdentity option for node aka "ws" ( NodeWebSocket = require('ws') )

https://nodejs.org/api/tls.html#tls_tls_checkserveridentity_hostname_cert
@djgorilla
Copy link
Author

PR: #616

@djgorilla
Copy link
Author

everybody that needs it asap:

package.json
"resolutions": {
"socket.io-client/**/engine.io-client": "https://github.com/djgorilla/engine.io-client.git"
},

@darrachequesne darrachequesne added the enhancement New feature or request label Jun 4, 2020
darrachequesne added a commit that referenced this issue Jan 14, 2021
@darrachequesne
feat: add missing ws options
d134fee 
Reference: https://github.com/websockets/ws/blob/master/doc/ws.md#new-websocketaddress-protocols-options

Related:

- #574
- #615
@darrachequesne
Copy link
Member

Closed by d134fee (included in engine.io-client@4.1.0)

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djgorilla @darrachequesne