Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add checkServerIdentity option #616

Closed
wants to merge 7 commits into from
Closed

Conversation

djgorilla
Copy link

Note: the engine.io.js file is the generated output of make engine.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • [] a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

not able to set checkServerIdentity

New behaviour

able to set checkServerIdentity

Other information (e.g. related issues)

const io = require('socket.io-client');
const fs = require('fs')

const client = io('wss://localhost:3030', {
transports: ['websocket'],
secure: true,
ca: fs.readFileSync('./server_cert.pem'),
cert: fs.readFileSync('./user_cert.pem'),
key: fs.readFileSync('./user_key.pem'),
checkServerIdentity: () => { return null },
});

@baileyherbert
Copy link

baileyherbert commented Dec 20, 2019

@darrachequesne Please check on this simple addition! Until it's merged, engine.io-client will not work for self-signed, hostless SSL certificates, which are common for internal networking – https://nodejs.org/api/tls.html#tls_tls_checkserveridentity_hostname_cert

@darrachequesne
Copy link
Member

Merged as d134fee. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants